wu-sheng commented on a change in pull request #7229:
URL: https://github.com/apache/skywalking/pull/7229#discussion_r662733558
##########
File path:
apm-sniffer/apm-sdk-plugin/spring-plugins/spring-webflux-5.x-webclient-plugin/src/main/java/org/apache/skywalking/apm/plugin/spring/webflux/v5/webclient/WebFluxWebClientInterceptor.java
##########
@@ -63,12 +65,12 @@ public void beforeMethod(EnhancedInstance objInst, Method
method, Object[] allAr
if (request instanceof EnhancedInstance) {
((EnhancedInstance)
request).setSkyWalkingDynamicField(contextCarrier);
}
-
+
//user async interface
span.prepareForAsync();
ContextManager.stopSpan();
- objInst.setSkyWalkingDynamicField(span);
+ spanLocal.set(span);
Review comment:
Check plugin API, we have MIC to propagate this reference to after
stage, and 100% safe, also have better performance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
