wu-sheng commented on a change in pull request #7249:
URL: https://github.com/apache/skywalking/pull/7249#discussion_r664019839
##########
File path:
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/CoreModuleConfig.java
##########
@@ -182,6 +182,12 @@
@Setter
private boolean enableEndpointNameGroupingByOpenapi = true;
+ /**
+ * The maximum size in bytes allowed for request headers.
+ * Use -1 to disable it.
+ */
+ private int httpMaxRequestHeaderSize = 8192;
Review comment:
Is this the default value of Jetty?
##########
File path: docs/en/setup/backend/configuration-vocabulary.md
##########
@@ -12,6 +12,7 @@ core|default|role|Option values, `Mixed/Receiver/Aggregator`.
**Receiver** mode
| - | - | restIdleTimeOut| Connector idle timeout in milliseconds of restful
service| SW_CORE_REST_JETTY_IDLE_TIMEOUT|30000|
| - | - | restAcceptorPriorityDelta| Thread priority delta to give to acceptor
threads of restful service| SW_CORE_REST_JETTY_DELTA|0|
| - | - | restAcceptQueueSize| ServerSocketChannel backlog of restful
service| SW_CORE_REST_JETTY_QUEUE_SIZE|0|
+| - | - | httpMaxRequestHeaderSize| Maximum request header size accepted|
SW_CORE_HTTP_MAX_REQUEST_HEADER_SIZE|8192|
Review comment:
You miss the sharing server config in here.
##########
File path: oap-server/server-bootstrap/src/main/resources/application.yml
##########
@@ -296,6 +297,7 @@ receiver-sharing-server:
restIdleTimeOut: ${SW_RECEIVER_SHARING_JETTY_IDLE_TIMEOUT:30000}
restAcceptorPriorityDelta: ${SW_RECEIVER_SHARING_JETTY_DELTA:0}
restAcceptQueueSize: ${SW_RECEIVER_SHARING_JETTY_QUEUE_SIZE:0}
+ httpMaxRequestHeaderSize: ${SW_CORE_HTTP_MAX_REQUEST_HEADER_SIZE:8192}
Review comment:
```suggestion
httpMaxRequestHeaderSize:
${SW_RECEIVER_SHARING_HTTP_MAX_REQUEST_HEADER_SIZE:8192}
```
##########
File path: docs/en/setup/backend/configuration-vocabulary.md
##########
@@ -12,6 +12,7 @@ core|default|role|Option values, `Mixed/Receiver/Aggregator`.
**Receiver** mode
| - | - | restIdleTimeOut| Connector idle timeout in milliseconds of restful
service| SW_CORE_REST_JETTY_IDLE_TIMEOUT|30000|
| - | - | restAcceptorPriorityDelta| Thread priority delta to give to acceptor
threads of restful service| SW_CORE_REST_JETTY_DELTA|0|
| - | - | restAcceptQueueSize| ServerSocketChannel backlog of restful
service| SW_CORE_REST_JETTY_QUEUE_SIZE|0|
+| - | - | httpMaxRequestHeaderSize| Maximum request header size accepted|
SW_CORE_HTTP_MAX_REQUEST_HEADER_SIZE|8192|
Review comment:
You miss the sharing server config in this doc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
