wallezhang commented on pull request #7271:
URL: https://github.com/apache/skywalking/pull/7271#issuecomment-877030036


   > I'm kind of concerned that `RESPONSE_CODE` and `STATUS_CODE` may be 
somewhat ambiguous as they have very similar names but no indicators to say 
what scenario they are specifically aimed at, I can only see "http and 
non-http" in the code comments. Is it a good idea to have these 2 tags 
simultaneously? @wu-sheng WDYT?
   
   Status code is defined in http protocol, and I think this tag is just for 
recording http status code. Other non-http requests also have their own 
response code definitions. So I think reusing status code tag may not be a good 
idea.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to