Lighfer opened a new issue #7343: URL: https://github.com/apache/skywalking/issues/7343
Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion - [x] Bug - [ ] Requirement - [ ] Feature or performance improvement ___ ### Bug https://github.com/apache/skywalking/blob/62411964a46aa22d47319ca863feed3a39169548/oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/prometheus/PrometheusMetricConverter.java#L87-L100 I think `Line 91` should be: ```java .filter(t -> t != NIL && t._2.samples.length > 0) ``` because `line 98` will throw an `IllegalArgumentException` if `samples.length == 0`. --- https://github.com/apache/skywalking/blob/62411964a46aa22d47319ca863feed3a39169548/oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/dsl/SampleFamily.java#L75-L79 I think `line 78` should be: ```java return new SampleFamily(Arrays.stream(samples).filter(sample -> !Double.isNaN(sample.getValue())).toArray(Sample[]::new), Optional.ofNullable(ctx).orElseGet(RunningContext::instance)); ``` because sample's value may be 'NaN'. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
