hanahmily commented on a change in pull request #23:
URL: https://github.com/apache/skywalking-banyandb/pull/23#discussion_r676115444
##########
File path: api/proto/Makefile
##########
@@ -15,19 +15,14 @@
# specific language governing permissions and limitations
# under the License.
-
-VERSION ?= v1
-fbs := $(wildcard $(VERSION)/*.fbs)
-GO_FLAGS := --go-namespace $(VERSION) --gen-onefile
-JAVA_FLAGS := --gen-generated
+CC = protoc
.PHONY: generate
generate: generate-go
.PHONY: generate-go
-generate-go: $(fbs)
- flatc --go --grpc $(GO_FLAGS) -o $(VERSION) $^
-
-.PHONY: generate-java
-generate-java: $(fbs)
- flatc --java --grpc $(JAVA_FLAGS) -o $(VERSION) $^
\ No newline at end of file
+generate-go:
Review comment:
Would we leverage https://github.com/bufbuild/buf to check proto files
and generate stubs?
##########
File path: banyand/series/trace/write.go
##########
@@ -55,13 +54,16 @@ func (t *traceSeries) Write(seriesID common.SeriesID,
shardID uint, entity data.
seriesIDBytes := convert.Uint64ToBytes(intSeriesID)
wp := t.writePoint(ts)
- err = wp.TimeSeriesWriter(shardID, dataStoreName).Put(seriesIDBytes,
entityVal.DataBinaryBytes(), ts)
+ err = wp.TimeSeriesWriter(shardID, dataStoreName).Put(seriesIDBytes,
entityVal.GetDataBinary(), ts)
if err != nil {
- return 0, errors.Wrap(err, "failed to write traceSeries data")
+ return 0, errors.Wrap(err, "fail to write traceSeries data")
}
- builder := flatbuffers.NewBuilder(0)
- builder.Finish(fb.CopyFields(entityVal, builder))
- err = wp.TimeSeriesWriter(shardID, fieldsStoreName).Put(seriesIDBytes,
builder.FinishedBytes(), ts)
+
+ byteVal, err := proto.Marshal(entityVal)
Review comment:
entityVal should write into fieldsStore without databinary. Could you
extract fields from entityVal, then save them into the below kv store?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
