wu-sheng commented on a change in pull request #50:
URL: https://github.com/apache/skywalking-eyes/pull/50#discussion_r676218032
##########
File path: pkg/deps/maven_test.go
##########
@@ -0,0 +1,56 @@
+package deps_test
Review comment:
About this test case, I can't see you check the expected jars list.
Could you enhance this test case? And notice, `test` and `provided` scopes
should not be checked, both these are not dependency check scope.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
