lujiajing1126 commented on a change in pull request #24:
URL: https://github.com/apache/skywalking-banyandb/pull/24#discussion_r676313789
##########
File path: go.mod
##########
@@ -6,22 +6,23 @@ require (
github.com/RoaringBitmap/roaring v0.9.1
github.com/cespare/xxhash v1.1.0
github.com/dgraph-io/badger/v3 v3.2011.1
- github.com/golang/mock v1.3.1
+ github.com/golang/mock v1.5.0
github.com/golang/protobuf v1.5.2
github.com/google/go-cmp v0.5.6
+ github.com/klauspost/compress v1.13.1 // indirect
github.com/oklog/run v1.1.0
github.com/pkg/errors v0.9.1
github.com/rs/zerolog v1.23.0
- github.com/spf13/cobra v1.1.3
+ github.com/spf13/cobra v1.2.1
github.com/spf13/pflag v1.0.5
- github.com/spf13/viper v1.7.1
+ github.com/spf13/viper v1.8.1
github.com/stretchr/testify v1.7.0
go.uber.org/atomic v1.7.0
- go.uber.org/multierr v1.6.0
+ go.uber.org/multierr v1.7.0
golang.org/x/net v0.0.0-20210716203947-853a461950ff // indirect
golang.org/x/sys v0.0.0-20210630005230-0f9fa26af87c // indirect
google.golang.org/genproto v0.0.0-20210722135532-667f2b7c528f //
indirect
- google.golang.org/grpc v1.39.0
+ google.golang.org/grpc v1.40.0-dev.0.20210623211556-d9eb12feed7a
Review comment:
Why do we need to update to an unstable version `1.40.0-dev`?
##########
File path: banyand/index/gomock_reflect_786311153/prog.go
##########
@@ -0,0 +1,66 @@
+
+package main
+
+import (
+ "encoding/gob"
+ "flag"
+ "fmt"
+ "os"
+ "path"
+ "reflect"
+
+ "github.com/golang/mock/mockgen/model"
+
+ pkg_ "github.com/apache/skywalking-banyandb/banyand/index"
+)
+
+var output = flag.String("output", "", "The output file name, or empty to use
stdout.")
+
+func main() {
Review comment:
what's the purpose of this file?
##########
File path: .github/workflows/go.yml
##########
@@ -39,8 +39,6 @@ jobs:
uses: apache/skywalking-eyes@5c90c9698806040f50671a172a7cac17974ecebd
- name: Update dependencies
run: GOPROXY=https://proxy.golang.org go mod download
- - name: Install Protoc
Review comment:
If we remove this, we should install `protoc` in another way
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
