kezhenxu94 commented on a change in pull request #7399:
URL: https://github.com/apache/skywalking/pull/7399#discussion_r683996107
##########
File path: docs/en/setup/envoy/metrics_service_setting.md
##########
@@ -86,6 +86,25 @@ istioctl manifest install -y \
--set 'meshConfig.defaultConfig.proxyStatsMatcher.inclusionRegexps[0]=.*'
```
+Note:
+`proxyStatsMatcher` only supported by `Istio 1.8+`.
+We recommend using `inclusionRegexps` to reserve the specific metrics which
need to analyze that can reduce Memory and CPU overhead.
+For example, OAP used these metrics:
+
+```shell
+istioctl manifest install -y \
+ --set profile=demo `# replace the profile as per your need` \
Review comment:
```suggestion
--set profile=demo # replace the profile as per your need \
```
##########
File path:
oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/Analyzer.java
##########
@@ -240,11 +242,23 @@ private void send(final AcceptableValue<?> v, final long
time) {
}
private void generateTraffic(MeterEntity entity) {
- ServiceTraffic s = new ServiceTraffic();
- s.setName(requireNonNull(entity.getServiceName()));
- s.setNodeType(NodeType.Normal);
-
s.setTimeBucket(TimeBucket.getMinuteTimeBucket(System.currentTimeMillis()));
- MetricsStreamProcessor.getInstance().in(s);
+ if (entity.getDetectPoint() != null) {
+ switch (entity.getDetectPoint()) {
+ case SERVER:
+ entity.setServiceName(entity.getDestServiceName());
+ toService(requireNonNull(entity.getDestServiceName()));
+ serverSide(entity);
+ break;
+ case CLIENT:
+ entity.setServiceName(entity.getSourceServiceName());
+ toService(requireNonNull(entity.getSourceServiceName()));
+ clientSide(entity);
+ break;
+ }
Review comment:
We should generate service traffic for both `source service` and `target
service`? And that might be the reason for
https://github.com/apache/skywalking/pull/7399/files#r683436684?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
