mrproliu commented on pull request #7495: URL: https://github.com/apache/skywalking/pull/7495#issuecomment-902445631
> > > Another feature request: can we provide an `env` field that allow to pass environments downwards into the container in Github Action environment. > > > > > > Could you do more explain on this? which environment field do you want? > > @mrproliu > > In the current E2E workflow, `SW_AGENT_JDK_VERSION` is defined to indicate the JDK version we intend to use for the test. > > https://github.com/apache/skywalking/blob/cf03304a48a940f5d599b3a2cbd0711b008c17d1/.github/workflows/e2e.storages.yaml#L24-L25 > > This variable is used in the `docker-compose.yml` file as a docker-build argument, i.e. `FROM adoptopenjdk/openjdk${SW_AGENT_JDK_VERSION}:alpine`. > > https://github.com/apache/skywalking/blob/cf03304a48a940f5d599b3a2cbd0711b008c17d1/test/e2e/e2e-test/docker/base-compose.yml#L85-L86 > > and, > > https://github.com/apache/skywalking/blob/cf03304a48a940f5d599b3a2cbd0711b008c17d1/test/e2e/e2e-test/docker/Dockerfile.provider#L16-L19 > > But this feature is missing in the state-of-art sw-infra-e2e framework according to the `action.yml`. > > https://github.com/apache/skywalking-infra-e2e/blob/de5be41596f27867a15ab75dbad97ea538d863b8/action.yaml#L31-L35 > > Ping @kezhenxu94 . Do you have other consideration for this scenario? for example this is an intentional design Thanks for your explain, Do you mean you want to correlate the GitHub Action environment into the Infra-E2E container? I think we missed that, so we can't correlate the GitHub Action Environment into E2E for now. I think we could dump the environment and use `--env-file` to propagate it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
