lpcy commented on pull request #18: URL: https://github.com/apache/skywalking-java/pull/18#issuecomment-912228571
> First, why plugin tests fail? > > > When my java application depend on multi-db-instance on same host:port，I always got wrong db.instance value in skywalking-ui. I found the same problem on that issue, there is a bad cache design in MySQL agent plugin, so I fix it. > > Then, you don't explain what is wrong, and how you fix. `Found one` and `fix it` don't make sense for reviewers. I'm still look for the failure... The problem is, if I use multi-db-instance with same host:port in one application, the code for putting connection info in cache will overwrite previous data due to duplicate host:port key, the previous db instance info will be lost, and also cannot get correct connection info from cache after that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
