lpcy commented on pull request #18: URL: https://github.com/apache/skywalking-java/pull/18#issuecomment-912948153
OK, but wrong db.instance value displayed on skywalking-ui cannot be tolerated to me, so I suggest fix it after all. My code don't affect value of cache (i.e. ConnectionInfo) but only key, and there are few code location to call get(host,port,databaseName) method, so it doesn't affect the current status that "ip and port represents a database instance". Now my code passed by all checks, please consider the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
