wu-sheng commented on a change in pull request #8012:
URL: https://github.com/apache/skywalking/pull/8012#discussion_r736607743
##########
File path:
oap-server/server-storage-plugin/storage-elasticsearch-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/elasticsearch/query/MetricsQueryEsDAO.java
##########
@@ -107,33 +106,31 @@ public MetricsValues readMetricsValues(final
MetricsCondition condition,
}
return id;
}).collect(Collectors.toList());
+
MetricsValues metricsValues = new MetricsValues();
SearchResponse response = getClient().ids(tableName, ids);
- if (response.getHits().getHits().isEmpty()) {
- return metricsValues;
- }
Review comment:
@kezhenxu94 I noticed this was changed within your ElasticSearch client
re-implementation(through git logs, maybe be wrong). We shouldn't do `return
fast`, due to no `filled array of default value` could cause UI error.
Also, this makes CLI query result as `[]`(empty array), which is not
consistent other storage implementations. Meanwhile, break the e2e(v2).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
