kezhenxu94 commented on a change in pull request #46:
URL: https://github.com/apache/skywalking-swck/pull/46#discussion_r745608829



##########
File path: hack/prepare-e2e.sh
##########
@@ -0,0 +1,108 @@
+
+#!/usr/bin/env bash
+
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+OS=$(go env GOOS)
+ARCH=$(go env GOHOSTARCH)
+
+INSTALL_DIR=/usr/local/bin
+IMAGE_FILE=test/e2e/e2e.yaml
+
+prepare_ok=true
+# install e2e
+function install_e2e()
+{
+    if ! command -v e2e &> /dev/null; then
+      echo "please refer 
https://github.com/apache/skywalking-infra-e2e/blob/main/docs/en/contribution/Compiling-Guidance.md
 to install e2e!"
+      $prepare_ok=false
+    fi
+}

Review comment:
       This is no needed if 
https://github.com/apache/skywalking-swck/pull/46/files#r745608218

##########
File path: hack/prepare-e2e.sh
##########
@@ -0,0 +1,108 @@
+
+#!/usr/bin/env bash
+
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+OS=$(go env GOOS)
+ARCH=$(go env GOHOSTARCH)
+
+INSTALL_DIR=/usr/local/bin
+IMAGE_FILE=test/e2e/e2e.yaml
+
+prepare_ok=true
+# install e2e
+function install_e2e()
+{
+    if ! command -v e2e &> /dev/null; then
+      echo "please refer 
https://github.com/apache/skywalking-infra-e2e/blob/main/docs/en/contribution/Compiling-Guidance.md
 to install e2e!"
+      $prepare_ok=false
+    fi
+}
+# install docker
+function install_docker()
+{
+    if ! command -v docker &> /dev/null; then
+      echo "please refer https://docs.docker.com/get-docker/ to install 
docker!"
+      $prepare_ok=false
+    fi 
+}
+# install kind
+function install_kind()
+{
+    if ! command -v kind &> /dev/null; then
+      echo "please refer https://kind.sigs.k8s.io/docs/user/quick-start to 
install kind!"
+      $prepare_ok=false
+    fi
+}

Review comment:
       This is not needed




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to