kezhenxu94 commented on a change in pull request #2:
URL: https://github.com/apache/skywalking-showcase/pull/2#discussion_r748047176
##########
File path: Makefile.in
##########
@@ -26,6 +26,8 @@ TAG ?= $(shell git rev-parse --short HEAD)
ES_VERSION ?= 7.10.0
+BUSYBOX_VERSION ?= 1.30
Review comment:
The variables in this file is meant to be updated by users when they
want to change the behaviors of the showcase but the busybox version seems to
be unnecessary to update, in users opinion. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
