kezhenxu94 commented on a change in pull request #46:
URL: https://github.com/apache/skywalking-swck/pull/46#discussion_r750078239
##########
File path: Makefile
##########
@@ -50,6 +50,18 @@ clean:
test: generate operator-manifests
go test ./... -coverprofile cover.out
+# Run e2e-test
+e2e-test:
Review comment:
Take this as an example of how to install required tools in e2e, the
idea is not to involve other tools (`make` in this case) as mush as possible
https://github.com/apache/skywalking/blob/b63008c61e1fcb1d69b25a8be7ce99f1d987a175/test/e2e-v2/cases/istio/als/e2e.yaml#L30-L36
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
