BFergerson commented on pull request #118:
URL: https://github.com/apache/skywalking-java/pull/118#issuecomment-1059804947


   > If there are too many threads, try to print all span creating and span 
closing with trace ID, segment ID and span ID. Then check the breaking segment 
with the trace id. Then you may notice which spans are missed.
   > 
   > Logs like this would help
   > 
   > ```
   > TraceID, xxxx, SegmentID, xxxx, SpanID, xxxxx, created.
   > TraceID, xxxx, SegmentID, xxxx, SpanID, xxxxx, closed. 
   > TraceID, xxxx, SegmentID, xxxx, SpanID, xxxxx, referring to TraceID yyyy, 
SegmentID yyyy, SpanID yyyy
   > ```
   
   Thanks, adding logging was useful. I also refactored `GlobalIdGenerator` to 
return simple reproducible outputs. That made it almost impossible not to see 
the issue. Maybe you've thought about having reproducible ids for testing 
scenarios? It might help given my fix 
(https://github.com/apache/skywalking-java/pull/119) doesn't change the 
expected data.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to