wu-sheng commented on code in PR #146:
URL: https://github.com/apache/skywalking-java/pull/146#discussion_r844919090
##########
apm-sniffer/apm-agent/src/main/java/org/apache/skywalking/apm/agent/SkyWalkingAgent.java:
##########
@@ -138,6 +138,8 @@ public static void premain(String agentArgs,
Instrumentation instrumentation) th
Runtime.getRuntime()
.addShutdownHook(new Thread(ServiceManager.INSTANCE::shutdown,
"skywalking service shutdown thread"));
+
+ SnifferConfigInitializer.pluginInitCompleted();
Review Comment:
Also, `Executors.newSingleThreadScheduledExecutor` is not just used in
**FileWriter**, others like `JVMService` service used them too. I think put
`SnifferConfigInitializer.pluginInitCompleted();` here would make more logs
disappeared. You just need this at L131, right after
`installOn(instrumentation)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
