Cool-Coding commented on code in PR #146: URL: https://github.com/apache/skywalking-java/pull/146#discussion_r847025124
########## apm-sniffer/bootstrap-plugins/jdk-threadpool-plugin/src/main/java/org/apache/skywalking/apm/plugin/wrapper/SwRunnableWrapper.java: ########## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * +*/ + +package org.apache.skywalking.apm.plugin.wrapper; + +import org.apache.skywalking.apm.agent.core.context.ContextManager; +import org.apache.skywalking.apm.agent.core.context.ContextSnapshot; +import org.apache.skywalking.apm.agent.core.context.trace.AbstractSpan; +import org.apache.skywalking.apm.network.trace.component.ComponentsDefine; + +public class SwRunnableWrapper implements Runnable { + + private Runnable runnable; + + private ContextSnapshot contextSnapshot; + + public SwRunnableWrapper(Runnable runnable, ContextSnapshot contextSnapshot) { + this.runnable = runnable; + this.contextSnapshot = contextSnapshot; + } + + @Override + public void run() { + AbstractSpan span = ContextManager.createLocalSpan(getOperationName()); Review Comment: > > And, have you known there are meter plugins for thread pool, such as `UndertowWorkerThreadPoolConstructorIntercept`. I think if this plugin covers the thread pool case too, it should report the thread pool metrics too. > > I've seen the issue before. I seen it again just now. it also instructs `ThreadPoolExecutor` with the match rule that package name is started with "org.xnio". If my `ThreadPoolExecutor` plugin covers this, the `Undertow ThreadPool` plugin is redundant I think. I will take it into account. > > Please take a look at [reply1](#discussion_r845039466), [reply2 ](#discussion_r845092153). I want to know your point of view. Thank you! @wu-sheng I am adding `ThreadPoolExecutor` metrics. But How to distinguish different thread pools？That is, how to determine the thread pool name. so far, I haven't thought of a meaningful name yet. Do you have any good suggestions? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
