Cool-Coding commented on code in PR #146:
URL: https://github.com/apache/skywalking-java/pull/146#discussion_r848062573
##########
apm-sniffer/apm-agent/src/main/java/org/apache/skywalking/apm/agent/SkyWalkingAgent.java:
##########
@@ -130,6 +130,8 @@ public static void premain(String agentArgs,
Instrumentation instrumentation) th
.with(new Listener())
.installOn(instrumentation);
+ SnifferConfigInitializer.pluginInitCompleted();
Review Comment:
I think `pluginInitCompleted` show belong to `SnifferConfigInitializer`.
the IS_PLUGIN_INIT_COMPLETED field is not a flag that indicates the plugins
are loaded. It's the flag that ByteBuddy has loaded all plugins. Before this,
ThreadPoolExecutor can't be created.
##########
apm-sniffer/apm-agent/src/main/java/org/apache/skywalking/apm/agent/SkyWalkingAgent.java:
##########
@@ -130,6 +130,8 @@ public static void premain(String agentArgs,
Instrumentation instrumentation) th
.with(new Listener())
.installOn(instrumentation);
+ SnifferConfigInitializer.pluginInitCompleted();
Review Comment:
I think `pluginInitCompleted` should belong to `SnifferConfigInitializer`.
the IS_PLUGIN_INIT_COMPLETED field is not a flag that indicates the plugins
are loaded. It's the flag that ByteBuddy has loaded all plugins. Before this,
ThreadPoolExecutor can't be created.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
