wu-sheng commented on code in PR #9128:
URL: https://github.com/apache/skywalking/pull/9128#discussion_r881369713


##########
oap-server/server-storage-plugin/storage-elasticsearch-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/elasticsearch/StorageModuleElasticsearchConfig.java:
##########
@@ -117,6 +117,12 @@ public class StorageModuleElasticsearchConfig extends 
ModuleConfig {
     private int scrollingBatchSize = 5000;
     private int segmentQueryMaxSize = 200;
     private int profileTaskQueryMaxSize = 200;
+    /**
+     * The batch size that used to scroll on the large eBPF profiling data 
result.
+     * The profiling data contains full symbol data, that could make 
ElasticSearch response large content,
+     * so could not same with {@link #scrollingBatchSize}.
+     */

Review Comment:
   ```suggestion
       /**
        * The batch size that is used to scroll on the large eBPF profiling 
data result.
        * The profiling data contains full-stack symbol data, which could make 
ElasticSearch response large content.
        *  {@link #scrollingBatchSize} would not be used in profiling data 
query.
        */
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to