tom-pytel commented on PR #210: URL: https://github.com/apache/skywalking-python/pull/210#issuecomment-1141462707
> I think you are right, this is indeed more robust. Probably adding a small FAQ documentation will be nice, so it eliminates user confusion. I was looking for a place to document this and found the following in `/docs/en/setup/EnvVars.md` the following: "SW_TRACE_IGNORE_PATH: You can setup multiple URL path patterns, The endpoints match these patterns wouldn't be traced. the current matching rules follow `Ant Path match style` , like /path/*, /path/**, /path/?" Then, looking up `Ant Path match style`: `**` matches zero or more 'directories' in a path And: `com/**/test.jsp` - matches all `test.jsp` files underneath the `com` path And: `org/springframework/**/*.jsp` - matches all `.jsp` files underneath the `org/springframework path` Which implies the previous behavior and test below did not actually follow the specification. Since now it does, there is nothing extra to document I think? ``` pattern = 'eureka/**/test/**' path = 'eureka/test/list' self.assertFalse(fast_path_match(pattern, path)) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
