dashanji commented on issue #9160: URL: https://github.com/apache/skywalking/issues/9160#issuecomment-1143589713
Thanks for this proposal. There are some tips for you. The CRD should contain the following configuration: 1. The [sidecar configuration](https://github.com/apache/skywalking-swck/blob/master/docs/java-agent-injector.md#configure-sidecar). As you said, the user can create a `sidecar template` to upgrade the agent. 2. The [annotation configuration](https://github.com/apache/skywalking-swck/blob/master/docs/java-agent-injector.md#use-annotations-to-overlay-default-agent-configuration). Users can create an `annotation template`. 3. The [labelselector](https://kubernetes.io/docs/concepts/overview/working-with-objects/labels/) to define which target object should be updated, like deployment/statefulset etc. The Controller should do the following things: 1. When the user creates/updates a CR, the controller can get the target object with the labelselector of the CR and inject the annotation to the target object. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
