Superskyyy commented on PR #211: URL: https://github.com/apache/skywalking-python/pull/211#issuecomment-1146168385
> > > > This addresses this [apache/skywalking#8556](https://github.com/apache/skywalking/discussions/8556) problem, right? Thanks for looking into this. > > > > > > > > > Should, yes. > > > > > > If you have verified it works for Django version above 3.10 then LGTM. :) > > There is a Django 3.10? I did do a quick test of our fork of this with Django 4.0.5 and it works, waiting on more thorough tests from the test monkeys though. LOL I forgot Django is already at 4.x. Btw we should bump up the checked versions in plugin supported matrix. ``` support_matrix = { 'django': { '>=3.6': ['3.2'], # ">=3.8": ["4.0a1"] # expected Dec 2021 } } ``` change to something like ``` support_matrix = { 'django': { '>=3.6': ['3.2'], ">=3.8': ['4.0'] # 4.2 will support py3.11 } } ``` BTW, do you think we should remove the support for 3.6? It has been sunsetted since 6 months ago. We will introduce some advanced features requiring 3.7 up, like the automatic post-fork hook. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
