hanahmily commented on code in PR #134:
URL:
https://github.com/apache/skywalking-banyandb/pull/134#discussion_r898668283
##########
api/proto/banyandb/common/v1/common.proto:
##########
@@ -33,9 +34,9 @@ enum Catalog {
// Metadata is for multi-tenant, multi-model use
message Metadata {
// group contains a set of options, like retention policy, max
- string group = 1;
+ string group = 1 [(validate.rules).string.min_len = 1];
Review Comment:
thank you for your reminding, the group field seems not be mandatory since
`Group` only has the `name`. Let's remove this checker here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
