sonatype-lift[bot] commented on code in PR #9377: URL: https://github.com/apache/skywalking/pull/9377#discussion_r930993234
########## oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/meter/function/sum/SumHistogramPercentileFunction.java: ########## @@ -0,0 +1,343 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + */ + +package org.apache.skywalking.oap.server.core.analysis.meter.function.sum; + +import com.google.common.base.Strings; +import io.vavr.Tuple; +import io.vavr.Tuple2; +import lombok.Getter; +import lombok.Setter; +import lombok.extern.slf4j.Slf4j; +import org.apache.skywalking.oap.server.core.Const; +import org.apache.skywalking.oap.server.core.UnexpectedException; +import org.apache.skywalking.oap.server.core.analysis.meter.Meter; +import org.apache.skywalking.oap.server.core.analysis.meter.MeterEntity; +import org.apache.skywalking.oap.server.core.analysis.meter.function.AcceptableValue; +import org.apache.skywalking.oap.server.core.analysis.meter.function.MeterFunction; +import org.apache.skywalking.oap.server.core.analysis.meter.function.PercentileArgument; +import org.apache.skywalking.oap.server.core.analysis.metrics.DataTable; +import org.apache.skywalking.oap.server.core.analysis.metrics.IntList; +import org.apache.skywalking.oap.server.core.analysis.metrics.Metrics; +import org.apache.skywalking.oap.server.core.analysis.metrics.MultiIntValuesHolder; +import org.apache.skywalking.oap.server.core.query.type.Bucket; +import org.apache.skywalking.oap.server.core.remote.grpc.proto.RemoteData; +import org.apache.skywalking.oap.server.core.storage.annotation.BanyanDB; +import org.apache.skywalking.oap.server.core.storage.annotation.Column; +import org.apache.skywalking.oap.server.core.storage.type.Convert2Entity; +import org.apache.skywalking.oap.server.core.storage.type.Convert2Storage; +import org.apache.skywalking.oap.server.core.storage.type.StorageBuilder; + +import java.util.Comparator; +import java.util.List; +import java.util.Objects; +import java.util.stream.Collector; +import java.util.stream.IntStream; + +import static java.util.stream.Collectors.groupingBy; +import static java.util.stream.Collectors.mapping; + +/** + * SumPercentile intends to calculate percentile based on the summary of raw values over the interval(minute, hour or day). + */ +@MeterFunction(functionName = "sumHistogramPercentile") +@Slf4j +public abstract class SumHistogramPercentileFunction extends Meter implements AcceptableValue<PercentileArgument>, MultiIntValuesHolder { + private static final String DEFAULT_GROUP = "pD"; + public static final String DATASET = "dataset"; + public static final String RANKS = "ranks"; + public static final String VALUE = "value"; + protected static final String SUMMATION = "summation"; + + @Setter + @Getter + @Column(columnName = ENTITY_ID) + @BanyanDB.ShardingKey(index = 0) + private String entityId; + @Getter + @Setter + @Column(columnName = VALUE, dataType = Column.ValueDataType.LABELED_VALUE, storageOnly = true) + private DataTable percentileValues = new DataTable(10); + @Getter + @Setter + @Column(columnName = SUMMATION, storageOnly = true) + protected DataTable summation = new DataTable(30); + /** + * Rank + */ + @Getter + @Setter + @Column(columnName = RANKS, storageOnly = true) + private IntList ranks = new IntList(10); + + private boolean isCalculated = false; + + @Override + public void accept(final MeterEntity entity, final PercentileArgument value) { + if (summation.size() > 0) { + if (!value.getBucketedValues().isCompatible(summation)) { + throw new IllegalArgumentException( + "Incompatible BucketedValues [" + value + "] for current PercentileFunction[" + summation + "]"); + } + } + + for (final int rank : value.getRanks()) { + if (rank <= 0) { + throw new IllegalArgumentException("Illegal rank value " + rank + ", must be positive"); + } + } + + if (ranks.size() > 0) { + if (ranks.size() != value.getRanks().length) { + throw new IllegalArgumentException( + "Incompatible ranks size = [" + value.getRanks().length + "] for current PercentileFunction[" + ranks + .size() + "]"); + } else { + for (final int rank : value.getRanks()) { + if (!ranks.include(rank)) { + throw new IllegalArgumentException( + "Rank " + rank + " doesn't exist in the previous ranks " + ranks); + } + } + } + } else { + for (final int rank : value.getRanks()) { + ranks.add(rank); + } + } + + this.entityId = entity.id(); + + String template = "%s"; + if (!Strings.isNullOrEmpty(value.getBucketedValues().getGroup())) { + template = value.getBucketedValues().getGroup() + ":%s"; + } + final long[] values = value.getBucketedValues().getValues(); + for (int i = 0; i < values.length; i++) { + long bucket = value.getBucketedValues().getBuckets()[i]; + String bucketName = bucket == Long.MIN_VALUE ? Bucket.INFINITE_NEGATIVE : String.valueOf(bucket); + String key = String.format(template, bucketName); + summation.valueAccumulation(key, values[i]); + } + + this.isCalculated = false; + } + + @Override + public boolean combine(final Metrics metrics) { + SumHistogramPercentileFunction percentile = (SumHistogramPercentileFunction) metrics; + + if (this.ranks.size() > 0) { + IntList ranksOfThat = percentile.getRanks(); + if (this.ranks.size() != ranksOfThat.size()) { + log.warn("Incompatible ranks size = [{}}] for current PercentileFunction[{}]", + ranksOfThat.size(), this.ranks.size() + ); + return true; + } else { + if (!this.ranks.equals(ranksOfThat)) { + log.warn("Rank {} doesn't exist in the previous ranks {}", ranksOfThat, this.ranks); + return true; + } + } + } + + this.summation.append(percentile.summation); + + this.isCalculated = false; + return true; + } + + @Override + public void calculate() { + if (!isCalculated) { + summation.keys().stream() + .map(key -> { + if (key.contains(":")) { + int index = key.lastIndexOf(":"); + return Tuple.of(key.substring(0, index), key); + } else { + return Tuple.of(DEFAULT_GROUP, key); + } + }) + .collect(groupingBy(Tuple2::_1, mapping(Tuple2::_2, Collector.of( + DataTable::new, + (dt, key) -> { + String v; + if (key.contains(":")) { + int index = key.lastIndexOf(":"); + v = key.substring(index + 1); + } else { + v = key; + } + dt.put(v, summation.get(key)); + }, + DataTable::append + )))) + .forEach((group, subDataset) -> { + long total; + total = subDataset.sumOfValues(); + + int[] roofs = new int[ranks.size()]; + for (int i = 0; i < ranks.size(); i++) { + roofs[i] = Math.round(total * ranks.get(i) * 1.0f / 100); + } + + int count = 0; + final List<String> sortedKeys = subDataset.sortedKeys(Comparator.comparingLong(Long::parseLong)); + + int loopIndex = 0; + + for (String key : sortedKeys) { + final Long value = subDataset.get(key); + + count += value; Review Comment: *[NarrowingCompoundAssignment](https://errorprone.info/bugpattern/NarrowingCompoundAssignment):* Compound assignments from Long to int hide lossy casts --- ```suggestion count = (int) (count + value); ``` --- Reply with *"**@sonatype-lift help**"* for info about LiftBot commands. Reply with *"**@sonatype-lift ignore**"* to tell LiftBot to leave out the above finding from this PR. Reply with *"**@sonatype-lift ignoreall**"* to tell LiftBot to leave out all the findings from this PR and from the status bar in Github. When talking to LiftBot, you need to **refresh** the page to see its response. [Click here](https://help.sonatype.com/lift/talking-to-lift) to get to know more about LiftBot commands. --- Was this a good recommendation? [ [🙁 Not relevant](https://www.sonatype.com/lift-comment-rating?comment=305348160&lift_comment_rating=1) ] - [ [😕 Won't fix](https://www.sonatype.com/lift-comment-rating?comment=305348160&lift_comment_rating=2) ] - [ [😑 Not critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=305348160&lift_comment_rating=3) ] - [ [🙂 Critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=305348160&lift_comment_rating=4) ] - [ [😊 Critical, fixing now](https://www.sonatype.com/lift-comment-rating?comment=305348160&lift_comment_rating=5) ] ########## oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/meter/function/sum/SumHistogramPercentileFunction.java: ########## @@ -0,0 +1,343 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + */ + +package org.apache.skywalking.oap.server.core.analysis.meter.function.sum; + +import com.google.common.base.Strings; +import io.vavr.Tuple; +import io.vavr.Tuple2; +import lombok.Getter; +import lombok.Setter; +import lombok.extern.slf4j.Slf4j; +import org.apache.skywalking.oap.server.core.Const; +import org.apache.skywalking.oap.server.core.UnexpectedException; +import org.apache.skywalking.oap.server.core.analysis.meter.Meter; +import org.apache.skywalking.oap.server.core.analysis.meter.MeterEntity; +import org.apache.skywalking.oap.server.core.analysis.meter.function.AcceptableValue; +import org.apache.skywalking.oap.server.core.analysis.meter.function.MeterFunction; +import org.apache.skywalking.oap.server.core.analysis.meter.function.PercentileArgument; +import org.apache.skywalking.oap.server.core.analysis.metrics.DataTable; +import org.apache.skywalking.oap.server.core.analysis.metrics.IntList; +import org.apache.skywalking.oap.server.core.analysis.metrics.Metrics; +import org.apache.skywalking.oap.server.core.analysis.metrics.MultiIntValuesHolder; +import org.apache.skywalking.oap.server.core.query.type.Bucket; +import org.apache.skywalking.oap.server.core.remote.grpc.proto.RemoteData; +import org.apache.skywalking.oap.server.core.storage.annotation.BanyanDB; +import org.apache.skywalking.oap.server.core.storage.annotation.Column; +import org.apache.skywalking.oap.server.core.storage.type.Convert2Entity; +import org.apache.skywalking.oap.server.core.storage.type.Convert2Storage; +import org.apache.skywalking.oap.server.core.storage.type.StorageBuilder; + +import java.util.Comparator; +import java.util.List; +import java.util.Objects; +import java.util.stream.Collector; +import java.util.stream.IntStream; + +import static java.util.stream.Collectors.groupingBy; +import static java.util.stream.Collectors.mapping; + +/** + * SumPercentile intends to calculate percentile based on the summary of raw values over the interval(minute, hour or day). + */ +@MeterFunction(functionName = "sumHistogramPercentile") +@Slf4j +public abstract class SumHistogramPercentileFunction extends Meter implements AcceptableValue<PercentileArgument>, MultiIntValuesHolder { + private static final String DEFAULT_GROUP = "pD"; + public static final String DATASET = "dataset"; + public static final String RANKS = "ranks"; + public static final String VALUE = "value"; + protected static final String SUMMATION = "summation"; + + @Setter + @Getter Review Comment: 💬 3 similar findings have been found in this PR --- *[MissingOverride](https://errorprone.info/bugpattern/MissingOverride):* getEntityId implements method in Meter; expected @Override --- ```suggestion @Override @Getter ``` --- <details><summary><b>Expand here to view all instances of this finding</b></summary><br/> <div align="center"> | **File Path** | **Line Number** | | ------------- | ------------- | | oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/meter/function/avg/AvgFunction.java | [74](https://github.com/mrproliu/skywalking/blob/206091f43d4cae9f3cc2fc04969ea848dfa746f3/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/meter/function/avg/AvgFunction.java#L74)| | oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/meter/Meter.java | [52](https://github.com/mrproliu/skywalking/blob/206091f43d4cae9f3cc2fc04969ea848dfa746f3/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/meter/Meter.java#L52)| | oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/meter/function/avg/AvgFunction.java | [53](https://github.com/mrproliu/skywalking/blob/206091f43d4cae9f3cc2fc04969ea848dfa746f3/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/meter/function/avg/AvgFunction.java#L53)| <p><a href="https://lift.sonatype.com/results/github.com/mrproliu/skywalking/01G8ZQNY24R5JW94V9CHW9DVPZ?t=ErrorProne|MissingOverride" target="_blank">Visit the Lift Web Console</a> to find more details in your report.</p></div></details> --- Reply with *"**@sonatype-lift help**"* for info about LiftBot commands. Reply with *"**@sonatype-lift ignore**"* to tell LiftBot to leave out the above finding from this PR. Reply with *"**@sonatype-lift ignoreall**"* to tell LiftBot to leave out all the findings from this PR and from the status bar in Github. When talking to LiftBot, you need to **refresh** the page to see its response. [Click here](https://help.sonatype.com/lift/talking-to-lift) to get to know more about LiftBot commands. --- Was this a good recommendation? [ [🙁 Not relevant](https://www.sonatype.com/lift-comment-rating?comment=305348146&lift_comment_rating=1) ] - [ [😕 Won't fix](https://www.sonatype.com/lift-comment-rating?comment=305348146&lift_comment_rating=2) ] - [ [😑 Not critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=305348146&lift_comment_rating=3) ] - [ [🙂 Critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=305348146&lift_comment_rating=4) ] - [ [😊 Critical, fixing now](https://www.sonatype.com/lift-comment-rating?comment=305348146&lift_comment_rating=5) ] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
