LL1024LL commented on issue #9397: URL: https://github.com/apache/skywalking/issues/9397#issuecomment-1197699534
> First of all, you should know, all codes have be included and tested through e2e > > 1. Nginx LUA proj, https://github.com/apache/skywalking-nginx-lua/blob/master/.github/workflows/e2e.yaml > 2. Kong proj, https://github.com/apache/skywalking-kong/blob/master/.github/workflows/e2e.yml > > We really run the plugin in the service, and verified the segments it reported. > > I am not the one writing all these codes, but I think it is better if you could find out what is the difference between your case and our e2e tests. Yes I konw, I read test file before to find some information . I notice the test conf has do some init work in nginx.conf, including call startBackendTimer function. [https://github.com/apache/skywalking-nginx-lua/blob/master/test/e2e/nginx/conf.d/nginx.conf#L44](https://github.com/apache/skywalking-nginx-lua/blob/master/test/e2e/nginx/conf.d/nginx.conf#L44) ``` init_worker_by_lua_block { local metadata_buffer = ngx.shared.tracing_buffer metadata_buffer:set("serviceName", "skywalking-nginx") -- Instance means the number of Nginx deployment, does not mean the worker instances metadata_buffer:set("serviceInstanceName", "e2e") -- set ignoreSuffix require("skywalking.util").set_ignore_suffix(".jpg,.jpeg,.js,.css,.png,.bmp,.gif,.ico,.mp3,.mp4,.svg") require("skywalking.util").set_randomseed() require("skywalking.client"):startBackendTimer("http://172.16.238.10:12800";) -- If there is a bug of this `tablepool` implementation, we can -- disable it in this way -- require("skywalking.util").disable_tablepool() skywalking_tracer = require("skywalking.tracer") } ``` I think this is why test case can pass? Just my guess. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
