hanahmily commented on PR #153: URL: https://github.com/apache/skywalking-banyandb/pull/153#issuecomment-1208874350
> We should make default values constants or variables and add comments for them rather than directly use them everywhere. Make sense, I will tweak them. > Instead of `2<<20` or `8<<20`, I prefer `1<<21` or `1<<24` which seems to be clearer. `8<<20` indicates the literal(8) and the unit(1<<20=1024*1024=1MB), which is more precise and straightforward than `1<<24`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
