kezhenxu94 commented on PR #132: URL: https://github.com/apache/skywalking-eyes/pull/132#issuecomment-1233622422
> @kezhenxu94 > > Haven't added `> /dev/null 2>&1` and `|| true` so that command is runnable in other platforms like windows(do we really need it?). I doubt whether it's runnable on Windows even you don't add that. Developers usually run this kind of commands in a Windows Linux Subsystem where `> /dev/null 2>&1` and `|| true` are supported. I just think cleaning the builder(and not to report issue in second run) is more important than running on Windows (I believe rare developers run this in a bare Windows terminal like `cmd` or Powershell. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
