SzyWilliam commented on code in PR #70:
URL: https://github.com/apache/skywalking-swck/pull/70#discussion_r964425919
##########
operator/apis/operator/v1alpha1/banyandb_types.go:
##########
@@ -0,0 +1,66 @@
+package v1alpha1
+
+import (
+ appsv1 "k8s.io/api/apps/v1"
+ corev1 "k8s.io/api/core/v1"
+ metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+)
+
+type BanyanDBSpec struct {
Review Comment:
@hanahmily should we expose total `PodTemplate` to user? I found that in
OapServer CRD we only expose some key fields like`Image`, while providing
default value for other fields. Should we follow this practice?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
