wu-sheng commented on code in PR #9614:
URL: https://github.com/apache/skywalking/pull/9614#discussion_r972620234


##########
oap-server/server-starter/src/main/resources/ui-initialized-templates/mysql/mysql-service.json:
##########
@@ -17,317 +17,345 @@
 
 [
    {
-      "id":"2981ef0e-1552-4cf0-a68c-da023b4a0fd8",
+      "id":"2ca19857-dcdb-491a-9739-d7ab79beb60b",
       "configuration":{
          "children":[
             {
                "x":0,
                "y":0,
-               "w":6,
-               "h":11,
+               "w":24,
+               "h":33,
                "i":"0",
-               "type":"Widget",
-               "metricTypes":[
-                  "readMetricsValue"
-               ],
-               "metrics":[
-                  "meter_mysql_uptime"
-               ],
-               "graph":{
-                  "type":"Card",
-                  "fontSize":40,
-                  "textAlign":"center",
-                  "showUnit":true
-               },
-               "metricConfig":[
+               "type":"Tab",
+               "children":[
                   {
-                     "calculation":"secondToDay"
-                  }
-               ],
-               "widget":{
-                  "title":"MySQL Uptime (day)"
-               }
-            },
-            {
-               "x":0,
-               "y":11,
-               "w":6,
-               "h":14,
-               "i":"1",
-               "type":"Widget",
-               "metricTypes":[
-                  "readMetricsValues"
-               ],
-               "metrics":[
-                  "meter_mysql_qps"
-               ],
-               "graph":{
-                  "type":"Line",
-                  "step":false,
-                  "smooth":false,
-                  "showSymbol":false,
-                  "showXAxis":true,
-                  "showYAxis":true
-               },
-               "widget":{
-                  "title":"Current QPS"
-               },
-               "value":"1",
-               "label":"1"
-            },
-            {
-               "x":12,
-               "y":0,
-               "w":6,
-               "h":11,
-               "i":"2",
-               "type":"Widget",
-               "metricTypes":[
-                  "readMetricsValue"
-               ],
-               "metrics":[
-                  "meter_mysql_innodb_buffer_pool_size"
-               ],
-               "graph":{
-                  "type":"Card",
-                  "fontSize":40,
-                  "textAlign":"center",
-                  "showUnit":true
-               },
-               "metricConfig":[
+                     "name":"Inspections",
+                     "children":[
+                        {
+                           "x":0,
+                           "y":0,
+                           "w":6,
+                           "h":9,
+                           "i":"0",
+                           "type":"Widget",
+                           "metricTypes":[
+                              "readMetricsValue"
+                           ],
+                           "metrics":[
+                              "meter_mysql_uptime"
+                           ],
+                           "graph":{
+                              "type":"Card",
+                              "fontSize":40,
+                              "textAlign":"center",
+                              "showUnit":true
+                           },
+                           "metricConfig":[
+                              {
+                                 "calculation":"secondToDay"
+                              }
+                           ],
+                           "widget":{
+                              "title":"MySQL Uptime (day)"
+                           }
+                        },
+                        {
+                           "x":0,
+                           "y":9,
+                           "w":6,
+                           "h":10,
+                           "i":"1",
+                           "type":"Widget",
+                           "metricTypes":[
+                              "readMetricsValues"
+                           ],
+                           "metrics":[
+                              "meter_mysql_qps"
+                           ],
+                           "graph":{
+                              "type":"Line",
+                              "step":false,
+                              "smooth":false,
+                              "showSymbol":false,
+                              "showXAxis":true,
+                              "showYAxis":true
+                           },
+                           "widget":{
+                              "title":"Current QPS"
+                           }
+                        },
+                        {
+                           "x":12,
+                           "y":0,
+                           "w":6,
+                           "h":9,
+                           "i":"2",
+                           "type":"Widget",
+                           "metricTypes":[
+                              "readMetricsValue"
+                           ],
+                           "metrics":[
+                              "meter_mysql_innodb_buffer_pool_size"
+                           ],
+                           "graph":{
+                              "type":"Card",
+                              "fontSize":40,
+                              "textAlign":"center",
+                              "showUnit":true
+                           },
+                           "metricConfig":[
+                              {
+                                 "calculation":"byteToMB"
+                              }
+                           ],
+                           "widget":{
+                              "title":"Innodb Buffer Pool Size (MB)"
+                           }
+                        },
+                        {
+                           "x":6,
+                           "y":0,
+                           "w":6,
+                           "h":9,
+                           "i":"3",
+                           "type":"Widget",
+                           "metricTypes":[
+                              "readMetricsValue"
+                           ],
+                           "metrics":[
+                              "meter_mysql_max_connections"
+                           ],
+                           "graph":{
+                              "type":"Card",
+                              "fontSize":40,
+                              "textAlign":"center",
+                              "showUnit":true
+                           },
+                           "widget":{
+                              "title":"Max Connections"
+                           }
+                        },
+                        {
+                           "x":18,
+                           "y":0,
+                           "w":6,
+                           "h":9,
+                           "i":"4",
+                           "type":"Widget",
+                           "metricTypes":[
+                              "readMetricsValue"
+                           ],
+                           "metrics":[
+                              "meter_mysql_thread_cache_size"
+                           ],
+                           "graph":{
+                              "type":"Card",
+                              "fontSize":40,
+                              "textAlign":"center",
+                              "showUnit":true
+                           },
+                           "widget":{
+                              "title":"Thread Cache Size"
+                           }
+                        },
+                        {
+                           "x":6,
+                           "y":9,
+                           "w":6,
+                           "h":10,
+                           "i":"5",
+                           "type":"Widget",
+                           "metricTypes":[
+                              "readMetricsValues"
+                           ],
+                           "metrics":[
+                              "meter_mysql_tps"
+                           ],
+                           "graph":{
+                              "type":"Line",
+                              "step":false,
+                              "smooth":false,
+                              "showSymbol":false,
+                              "showXAxis":true,
+                              "showYAxis":true
+                           },
+                           "widget":{
+                              "title":"Current TPS"
+                           }
+                        },
+                        {
+                           "x":12,
+                           "y":9,
+                           "w":6,
+                           "h":10,
+                           "i":"6",
+                           "type":"Widget",
+                           "metricTypes":[
+                              "readMetricsValues",
+                              "readMetricsValues",
+                              "readMetricsValues",
+                              "readMetricsValues"
+                           ],
+                           "metrics":[
+                              "meter_mysql_commands_insert_rate",
+                              "meter_mysql_commands_select_rate",
+                              "meter_mysql_commands_delete_rate",
+                              "meter_mysql_commands_update_rate"
+                           ],
+                           "graph":{
+                              "type":"Area",
+                              "opacity":0.4,
+                              "showXAxis":true,
+                              "showYAxis":true
+                           },
+                           "widget":{
+                              "title":"Commands Trend (rows per second)"
+                           }
+                        },
+                        {
+                           "x":6,
+                           "y":19,
+                           "w":6,
+                           "h":10,
+                           "i":"7",
+                           "type":"Widget",
+                           "metricTypes":[
+                              "readMetricsValues",
+                              "readMetricsValues",
+                              "readMetricsValues",
+                              "readMetricsValues"
+                           ],
+                           "metrics":[
+                              "meter_mysql_threads_cached",
+                              "meter_mysql_threads_running",
+                              "meter_mysql_threads_created",
+                              "meter_mysql_threads_connected"
+                           ],
+                           "graph":{
+                              "type":"Area",
+                              "opacity":0.4,
+                              "showXAxis":true,
+                              "showYAxis":true
+                           },
+                           "widget":{
+                              "title":"Threads"
+                           }
+                        },
+                        {
+                           "x":0,
+                           "y":19,
+                           "w":6,
+                           "h":10,
+                           "i":"8",
+                           "type":"Widget",
+                           "metricTypes":[
+                              "readMetricsValues",
+                              "readMetricsValues"
+                           ],
+                           "metrics":[
+                              "meter_mysql_connects_available",
+                              "meter_mysql_connects_aborted"
+                           ],
+                           "graph":{
+                              "type":"Line",
+                              "step":false,
+                              "smooth":false,
+                              "showSymbol":false,
+                              "showXAxis":true,
+                              "showYAxis":true
+                           },
+                           "widget":{
+                              "title":"Connects"
+                           }
+                        },
+                        {
+                           "x":18,
+                           "y":9,
+                           "w":6,
+                           "h":10,
+                           "i":"10",
+                           "type":"Widget",
+                           "metricTypes":[
+                              "readMetricsValues"
+                           ],
+                           "metrics":[
+                              "meter_mysql_slow_queries_rate"
+                           ],
+                           "graph":{
+                              "type":"Line",
+                              "step":false,
+                              "smooth":false,
+                              "showSymbol":false,
+                              "showXAxis":true,
+                              "showYAxis":true
+                           },
+                           "widget":{
+                              "title":"Slow Queries Trend (queries per second)"
+                           }
+                        },
+                        {
+                           "x":12,
+                           "y":19,
+                           "w":6,
+                           "h":10,
+                           "i":"11",
+                           "type":"Widget",
+                           "metricTypes":[
+                              "readMetricsValues",
+                              "readMetricsValues"
+                           ],
+                           "metrics":[
+                              "meter_mysql_connection_errors_internal",
+                              "meter_mysql_connection_errors_max_connections"
+                           ],
+                           "graph":{
+                              "type":"Line",
+                              "step":false,
+                              "smooth":false,
+                              "showSymbol":false,
+                              "showXAxis":true,
+                              "showYAxis":true
+                           },
+                           "widget":{
+                              "title":"Connection Errors"
+                           }
+                        }
+                     ]
+                  },
                   {
-                     "calculation":"byteToMB"
+                     "name":"Slow Statements",
+                     "children":[
+                        {
+                           "x":0,
+                           "y":0,
+                           "w":24,
+                           "h":29,
+                           "i":"0",
+                           "type":"Widget",
+                           "metricTypes":[
+                              "readSampledRecords"
+                           ],
+                           "metrics":[
+                              "top_n_database_statement"

Review Comment:
   Do we support to set N for sampled record on UI?
   As you use a whole page to show. Top 50 seems better.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to