wu-sheng commented on code in PR #9622:
URL: https://github.com/apache/skywalking/pull/9622#discussion_r972981440
##########
test/e2e-v2/cases/meter/meter-cases.yaml:
##########
@@ -31,4 +31,50 @@
curl -s -XPOST http://${sender_host}:${sender_9093}/sendBatchMetrics >
/dev/null;
sleep 10;
swctl --display yaml
--base-url=http://${oap_host}:${oap_12800}/graphql metrics linear
--name=batch_test --instance-name=test-instance --service-name=test-service |yq
e 'to_entries' -
- expected: expected/metrics-has-value.yml
\ No newline at end of file
+ expected: expected/metrics-has-value.yml
+ # virtual cache
+ - query: |
+ swctl --display yaml
--base-url=http://${oap_host}:${oap_12800}/graphql metrics linear
--name=cache_read_resp_time --service-id=R3VhdmFDYWNoZS1sb2NhbA==.0 | yq e
'to_entries' -
+ expected: expected/metrics-has-value0.yml
+ - query: |
+ swctl --display yaml
--base-url=http://${oap_host}:${oap_12800}/graphql metrics linear
--name=cache_read_sla --service-id=R3VhdmFDYWNoZS1sb2NhbA==.0 | yq e
'to_entries' -
+ expected: expected/metrics-has-value.yml
+ - query: |
+ swctl --display yaml
--base-url=http://${oap_host}:${oap_12800}/graphql metrics linear
--name=cache_read_cpm --service-id=R3VhdmFDYWNoZS1sb2NhbA==.0 | yq e
'to_entries' -
+ expected: expected/metrics-has-value.yml
+ - query: |
+ swctl --display yaml
--base-url=http://${oap_host}:${oap_12800}/graphql metrics multiple-linear
--name=cache_read_percentile --service-id=R3VhdmFDYWNoZS1sb2NhbA==.0 | yq e
'to_entries | with(.[] ; .value=(.value | to_entries))' -
+ expected: expected/metrics-has-value-percentile.yml
Review Comment:
To save cost and time in the CI, I think we don't have to test all metrics
of the virtual cache.
You could choose one metric and sampled record.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]