pg-yang commented on code in PR #9622: URL: https://github.com/apache/skywalking/pull/9622#discussion_r973587181
########## test/e2e-v2/cases/storage/storage-cases.yaml: ########## @@ -47,7 +47,7 @@ cases: - query: swctl --display yaml --base-url=http://${oap_host}:${oap_12800}/graphql trace ls expected: expected/traces-list.yml # negative tags search: relationship should be logical AND instead of logical OR - - query: swctl --display yaml --base-url=http://${oap_host}:${oap_12800}/graphql trace ls --tags http.method=POST,http.status_code=200 + - query: swctl --display yaml --base-url=http://${oap_host}:${oap_12800}/graphql trace ls --tags http.method=POST,http.status_code=200,iserror=true Review Comment: Before 258 PR , All http plugins only collect http code which max 400 , so the case was meet . But since 258 , http plugins collect all http code , and I updated `SW_AGENT_JAVA_COMMIT` to latest , so the the case couldn't meet . In order keep it correct , I added the param BTW the expected data of this case is `traces: []` . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
