jmjoy commented on code in PR #24:
URL: https://github.com/apache/skywalking-php/pull/24#discussion_r1000055450
##########
src/channel.rs:
##########
@@ -33,7 +33,7 @@ static RECEIVER: OnceCell<Mutex<Option<StdUnixStream>>> =
OnceCell::new();
pub fn init_channel() -> anyhow::Result<()> {
let (sender, receiver) = StdUnixStream::pair()?;
- sender.set_nonblocking(true)?;
+ sender.set_nonblocking(false)?;
Review Comment:
The design principle of skywalking agent should be to ensure that the main
programs are not affected.
If blocking, when the unix stream buffer is full or the grpc process hangs,
blocking will cause the php worker process to block.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
