kezhenxu94 commented on code in PR #9817:
URL: https://github.com/apache/skywalking/pull/9817#discussion_r1000168680
##########
oap-server/exporter/pom.xml:
##########
@@ -38,6 +38,11 @@
<artifactId>library-datacarrier-queue</artifactId>
<version>${project.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.kafka</groupId>
+ <artifactId>kafka-clients</artifactId>
+ <version>${kafka-clients.version}</version>
Review Comment:
Move the version management to oap-server-bom module
##########
oap-server/server-starter/src/main/resources/application.yml:
##########
@@ -433,7 +433,7 @@ alarm:
default:
telemetry:
- selector: ${SW_TELEMETRY:none}
+ selector: ${SW_TELEMETRY:prometheus}
Review Comment:
Do we want to change the default value?
##########
docs/en/setup/backend/exporter.md:
##########
@@ -0,0 +1,161 @@
+# Exporter
+SkyWalking provides the essential functions of metrics aggregation, trace,
log, alarm, and analysis.
+In many real-world scenarios, users may want to forward their data to a 3rd
party system for further in-depth analysis.
+**Exporter** has made that possible.
+
+The exporter is an independent module that has to be manually activated.
+
+Right now, we provide the following exporters:
+1. gRPC Exporter
+- Metrics
+2. Kafka Exporter
+- Trace
+- Log
+
+## gRPC Exporter
+### Metrics gRPC Exporter
+Metrics gRPC exporter uses SkyWalking's native exporter service definition.
Here is the proto definition.
+```proto
+service MetricExportService {
+ rpc export (stream ExportMetricValue) returns (ExportResponse) {
+ }
+
+ rpc subscription (SubscriptionReq) returns (SubscriptionsResp) {
+ }
Review Comment:
I would just link to the proto file instead of copying them here as they
might be outdated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
