wu-sheng commented on code in PR #376: URL: https://github.com/apache/skywalking-java/pull/376#discussion_r1014763021
########## apm-protocol/apm-network/src/main/java/org/apache/skywalking/apm/network/trace/component/ComponentsDefine.java: ########## @@ -231,4 +231,6 @@ public class ComponentsDefine { public static final OfficialComponent IMPALA_JDBC_DRIVER = new OfficialComponent(133, "Impala-jdbc-driver"); + public static final OfficialComponent EVENT_MESH = new OfficialComponent(134, "EventMesh"); Review Comment: https://github.com/apache/skywalking/blob/6984bbc65a4c12009e095e376b5e6ffb3a90db59/oap-server/server-starter/src/main/resources/component-libraries.yml#L434-L436 134 had been registered as Impala server, this is why we required for pre-registration before agent plugin PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org