mrproliu commented on code in PR #401: URL: https://github.com/apache/skywalking-java/pull/401#discussion_r1039066157
########## apm-application-toolkit/apm-toolkit-micrometer-registry/src/main/java/org/apache/skywalking/apm/toolkit/micrometer/observation/SkywalkingContextSnapshotThreadLocalAccessor.java: ########## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + */ + +package org.apache.skywalking.apm.toolkit.micrometer.observation; + +import io.micrometer.context.ThreadLocalAccessor; + +/** + * A {@link ThreadLocalAccessor} to put and restore current {@code ContextSnapshot} from APM agent. + */ +public class SkywalkingContextSnapshotThreadLocalAccessor implements ThreadLocalAccessor<Object> { Review Comment: > When we continue a span between threads, what should be the name of that continued span? It's usually decided by when you need to cross-thread. Such as when we submit a new thread, we called `Thread/{thread_name}/{running_function}`. > Also how can you reset the thread local with a span (how can I remove the active span from thread local) Here has a good [demo](https://github.com/apache/skywalking-java/blob/main/apm-sniffer/apm-toolkit-activation/apm-toolkit-trace-activation/src/main/java/org/apache/skywalking/apm/toolkit/activation/trace/CallableOrRunnableActivation.java), you could check this out. In this demo, we capture a snapshot from the tracing context and continue the snapshot in other thread. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
