wu-sheng commented on code in PR #10115: URL: https://github.com/apache/skywalking/pull/10115#discussion_r1041139689
########## .gitignore: ########## @@ -22,3 +22,4 @@ oap-server/oal-grammar/**/gen/ # This serves as a template but will ONLY be updated when building a source release tar, # so we don't track future updates of this file. oap-server/server-starter/src/main/resources/version.properties +test/e2e-v2/cases/mariadb/mariadb-slowsql/log/ Review Comment: This is an unexpected change. ```suggestion ``` I think the logs should not be generated in local disk. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
