This is an automated email from the ASF dual-hosted git repository.
yihaochen pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking-python.git
The following commit(s) were added to refs/heads/master by this push:
new 84253cc Fix uncancellable ci jobs due to always() condition (#259)
84253cc is described below
commit 84253ccbec63f83cf2980437e6f2b16506f59c7f
Author: Superskyyy <[email protected]>
AuthorDate: Mon Dec 12 00:37:50 2022 -0500
Fix uncancellable ci jobs due to always() condition (#259)
The always condition was blocking CI jobs upon cancellation.
---
.github/workflows/CI.yaml | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/.github/workflows/CI.yaml b/.github/workflows/CI.yaml
index 4bbd08d..54bb50e 100644
--- a/.github/workflows/CI.yaml
+++ b/.github/workflows/CI.yaml
@@ -104,7 +104,7 @@ jobs:
name: Build Plugin and UT Matrix
needs: [ license-and-lint, changes, plugin-doc-check ]
if: |
- always() &&
+ ( always() && ! cancelled() ) &&
((github.event_name == 'schedule' && github.repository ==
'apache/skywalking-python') || needs.changes.outputs.agent == 'true')
runs-on: ubuntu-latest
steps:
@@ -122,7 +122,7 @@ jobs:
name: Build Plugin Test Image
needs: [ license-and-lint, changes, plugin-doc-check,
prep-plugin-and-unit-tests ]
if: |
- always() &&
+ ( always() && ! cancelled() ) &&
((github.event_name == 'schedule' && github.repository ==
'apache/skywalking-python') || needs.changes.outputs.agent == 'true')
runs-on: ubuntu-latest
strategy:
@@ -153,7 +153,7 @@ jobs:
name: Plugin and Unit Tests
needs: [ license-and-lint, changes, plugin-doc-check, docker-plugin,
prep-plugin-and-unit-tests ]
if: |
- always() &&
+ ( always() && ! cancelled() ) &&
((github.event_name == 'schedule' && github.repository ==
'apache/skywalking-python') || needs.changes.outputs.agent == 'true')
runs-on: ubuntu-latest
timeout-minutes: 30
@@ -191,7 +191,7 @@ jobs:
name: Build E2E Test Image
needs: [ license-and-lint, changes, plugin-doc-check ]
if: |
- always() &&
+ ( always() && ! cancelled() ) &&
((github.event_name == 'schedule' && github.repository ==
'apache/skywalking-python') || needs.changes.outputs.agent == 'true')
runs-on: ubuntu-latest
timeout-minutes: 10
@@ -222,7 +222,7 @@ jobs:
name: E2E
needs: [ license-and-lint, changes, plugin-doc-check, docker-e2e ]
if: |
- always() &&
+ ( always() && ! cancelled() ) &&
((github.event_name == 'schedule' && github.repository ==
'apache/skywalking-python') || needs.changes.outputs.agent == 'true')
runs-on: ubuntu-latest
timeout-minutes: 20