wu-sheng commented on code in PR #10157: URL: https://github.com/apache/skywalking/pull/10157#discussion_r1048479384
########## oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/StorageID.java: ########## @@ -0,0 +1,159 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + */ + +package org.apache.skywalking.oap.server.core.storage; + +import java.util.ArrayList; +import java.util.Collections; +import java.util.List; +import java.util.Optional; +import lombok.EqualsAndHashCode; +import lombok.Getter; +import lombok.RequiredArgsConstructor; +import org.apache.skywalking.oap.server.library.util.StringUtil; + +/** + * StorageID represents an identification for the metric or the record. + * Typically, an ID is composited by two parts + * 1. Time bucket based on downsampling. + * 2. The encoded entity ID, such as Service ID. + * + * In the SQL database and ElasticSearch, the string ID is preferred. + * In the BanyanDB, time series and entity ID(series ID) would be treated separately. + * + * @since 9.4.0 StorageID replaced the `string id()` method in the StorageData. An object-oriented ID provides a more + * friendly interface for various database implementation. + */ +@EqualsAndHashCode(of = { + "fragments" +}) +public class StorageID { Review Comment: To all reviewers, this is the key point of all changes. This StorageID would represent the ID to replace the original string ID. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
