pg-yang commented on code in PR #10343: URL: https://github.com/apache/skywalking/pull/10343#discussion_r1096618544
########## oap-server/server-receiver-plugin/aws-firehose-receiver/README.MD: ########## @@ -0,0 +1,7 @@ +### Notice +The OTEL proto in this module copy from [opentelemetry-proto v0.7.0](https://github.com/open-telemetry/opentelemetry-proto/tree/v0.7.0) as AWS firehose only support OTEL 0.7, and rewrite follows : Review Comment: OTEL 0.7 has little difference from existing OTEL proto, for example: ``` instrumentationLibraryMetrics (0.7)-> scopeMetrics doubleSummary, intSummary (0.7) -> summary labels (0.7) -> attributes ``` These unmatched field name would miss some data if use `oap-server/server-receiver-plugin/receiver-proto/src/main/proto/opentelemetry`, so I convert 0.7 to existing OTEL proto, and change the java package to avoid class conflict -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
