wu-sheng commented on code in PR #239:
URL:
https://github.com/apache/skywalking-booster-ui/pull/239#discussion_r1113762854
##########
src/views/dashboard/data.ts:
##########
@@ -309,7 +309,7 @@ export const CalculationOpts = [
value: "convertMilliseconds",
},
{ label: "Seconds to YYYY-MM-DD HH:mm:ss", value: "convertSeconds" },
- { label: "Precision is 2", value: "precision" },
+ { label: "CPM5D", value: "cpm5d" },
Review Comment:
> Hardcoding this label to CPM5D looks unreasonable to me. This calculation
type can be selected even if the chart is not cpm, for example in the demo
video you can select CPM5D for the apdex charts. So I'm curious why not use the
previous label like Precision is 5 digits or so?
This is not a label, this is a formula to format data. Check existing ones,
there are things like `apdex`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
