mufiye commented on PR #10449: URL: https://github.com/apache/skywalking/pull/10449#issuecomment-1446398092
> If you want to learn this for now, then MAL is groovy based script. `SampleFamily` is the root class running in MAL engine, and this is the type referred by the metric name of the expression. You can see `SampleFamily#filter(Closure<Boolean> filter)`, this is what I mean about closure. It means a code block as an inner class for the metric process. We don't have a similar mechanism for this, but from what you described these buckets, we seem to need one for the exponential histogram. For example, we may need `buildBucketsFromExponentialHistogram(..., Closure<Boolean> processor)` as another new method. Then we could write some codes in the MAL expression to do `mutiple 1000`(ns -> ms) mentioned above. I think I need to fully understand the meter analyzer code first. In my current opinion, the function can not be put into the `OpenTelemetryMetricRequestProcessor#adaptMetrics` part and should be put in the analyzer part. And should we also consider small double data case for "otel histogram data"? Anyway, the difference between histogram and ExponentialHistogram is that the latter does the data compression. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
