wayilau commented on issue #3287: Add cached writer. URL: https://github.com/apache/skywalking/pull/3287#issuecomment-522816754 > `org.apache.skywalking.apm.agent.core.conf.Config.Logging#OUTPUT` is modifiable at runtime and the real writer may change, after your patch the modification of `Config.Logging#OUTPUT` takes no effect. > > Although I think we hardly ever change the `Config.Logging#OUTPUT` at runtime, but the unit tests do this in order to verify, so I think you should either modify the unit test accordingly, or keep everthing unchanged, WDYT @wu-sheng @kezhenxu94 I see. But why we change the output type at runtime? is there a real scene?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
