wu-sheng commented on code in PR #479:
URL: https://github.com/apache/skywalking-java/pull/479#discussion_r1135218173
##########
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/profile/ProfileTaskExecutionContext.java:
##########
@@ -48,7 +48,7 @@ public class ProfileTaskExecutionContext {
public ProfileTaskExecutionContext(ProfileTask task) {
this.task = task;
- profilingSegmentSlots = new
AtomicReferenceArray<>(Config.Profile.MAX_PARALLEL);
+ profilingSegmentSlots = new
AtomicReferenceArray<>(Config.Profile.MAX_PARALLEL *
(Config.Profile.MAX_ACCEPT_SUB_PARALLEL + 1));
Review Comment:
I think this may not current. This would cause `if (profilingEndpointCount
>= Config.Profile.MAX_PARALLEL) {` true even if the slots are still available.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
