wu-sheng commented on code in PR #10557:
URL: https://github.com/apache/skywalking/pull/10557#discussion_r1141018341
##########
oap-server/server-storage-plugin/storage-elasticsearch-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/elasticsearch/query/MetadataQueryEsDAO.java:
##########
@@ -76,17 +78,19 @@ public MetadataQueryEsDAO(
ElasticSearchClient client,
StorageModuleElasticsearchConfig config) {
super(client);
- this.queryMaxSize = config.getMetadataQueryMaxSize();
+ this.metadataMaxSize = config.getMetadataQueryMaxSize();
+ this.resultWindowMaxSize = config.getResultWindowMaxSize();
this.scrollingBatchSize = config.getScrollingBatchSize();
this.layerSize = Layer.values().length;
+ this.queryMaxSize = Math.min(metadataMaxSize, resultWindowMaxSize);
Review Comment:
> I change this because this is also limit by the elasticsearch
resultWindowMaxSize
Why don't you change the value to fix the expectation? The server setup
matters too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
