kezhenxu94 commented on code in PR #10473: URL: https://github.com/apache/skywalking/pull/10473#discussion_r1141943177
########## oap-server/server-storage-plugin/storage-jdbc-hikaricp-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/jdbc/common/dao/JDBCContinuousProfilingPolicyDAO.java: ########## @@ -0,0 +1,99 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + */ + +package org.apache.skywalking.oap.server.storage.plugin.jdbc.common.dao; + +import lombok.AllArgsConstructor; +import lombok.SneakyThrows; +import org.apache.skywalking.oap.server.core.profiling.continuous.storage.ContinuousProfilingPolicy; +import org.apache.skywalking.oap.server.core.storage.profiling.continuous.IContinuousProfilingPolicyDAO; +import org.apache.skywalking.oap.server.core.storage.type.HashMapConverter; +import org.apache.skywalking.oap.server.library.client.jdbc.hikaricp.JDBCClient; +import org.apache.skywalking.oap.server.library.util.CollectionUtils; +import org.apache.skywalking.oap.server.storage.plugin.jdbc.SQLExecutor; +import org.apache.skywalking.oap.server.storage.plugin.jdbc.TableMetaInfo; +import org.apache.skywalking.oap.server.storage.plugin.jdbc.common.JDBCTableInstaller; +import org.apache.skywalking.oap.server.storage.plugin.jdbc.common.TableHelper; + +import java.io.IOException; +import java.sql.Connection; +import java.sql.ResultSet; +import java.sql.SQLException; +import java.util.ArrayList; +import java.util.Arrays; +import java.util.Collections; +import java.util.List; +import java.util.stream.Collectors; + +@AllArgsConstructor +public class JDBCContinuousProfilingPolicyDAO extends JDBCSQLExecutor implements IContinuousProfilingPolicyDAO { + private final JDBCClient jdbcClient; + private final TableHelper tableHelper; + + @Override + public void savePolicy(ContinuousProfilingPolicy policy) throws IOException { + final List<ContinuousProfilingPolicy> existingPolicy = queryPolicies(Arrays.asList(policy.getServiceId())); + SQLExecutor sqlExecutor; + final var model = TableMetaInfo.get(ContinuousProfilingPolicy.INDEX_NAME); + if (CollectionUtils.isNotEmpty(existingPolicy)) { + sqlExecutor = getUpdateExecutor(model, policy, 0, new ContinuousProfilingPolicy.Builder(), null); + } else { + sqlExecutor = getInsertExecutor(model, policy, 0, + new ContinuousProfilingPolicy.Builder(), new HashMapConverter.ToStorage(), null); + } + + try (Connection connection = jdbcClient.getConnection()) { + sqlExecutor.invoke(connection); + } catch (SQLException e) { + throw new IOException(e); + } + } + + @SneakyThrows + @Override + public List<ContinuousProfilingPolicy> queryPolicies(List<String> serviceIdList) throws IOException { + final var tables = tableHelper.getTablesWithinTTL(ContinuousProfilingPolicy.INDEX_NAME); + List<Object> condition = new ArrayList<>(); + condition.add(ContinuousProfilingPolicy.INDEX_NAME); + condition.addAll(serviceIdList); + + StringBuilder whereQuery = new StringBuilder() + .append(" where ") + .append(JDBCTableInstaller.TABLE_COLUMN).append(" = ?") + .append(" and ").append(ContinuousProfilingPolicy.SERVICE_ID) + .append(" in ").append(serviceIdList.stream().map(s -> "?").collect(Collectors.joining(",", "(", ")"))); + for (String table : tables) { + return jdbcClient.executeQuery("select * from " + table + whereQuery, this::buildPolicies, condition.toArray(new Object[0])); + } + + return Collections.emptyList(); Review Comment: This is not fixed. You might want to change to ```suggestion final var results = new ArrayList<ContinuousProfilingPolicy>(); for (String table : tables) { results.addAll(jdbcClient.executeQuery("select * from " + table + whereQuery, this::buildPolicies, condition.toArray(new Object[0]))); } return results; ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
