toffentoffen commented on code in PR #110:
URL:
https://github.com/apache/skywalking-query-protocol/pull/110#discussion_r1142410342
##########
metric.graphqls:
##########
@@ -50,6 +50,8 @@ type KVInt {
# 1. If ask for cpm metric, the unit and result should be count.
# 2. If ask for response time (p99 or avg), the unit should be millisecond.
value: Long!
+ # Since 9.5.0, isEmptyValue indicates whether value == 0 represents
actually zero(false, default) or no data(true).
+ isEmptyValue: Boolean!
Review Comment:
If the return `value: 0` is not a real `0`, then set the `emptyValue=true`.
Otherwise, when the value is a real `0` or `>0` don't even return the
`emptyValue` property in the marshalled response.
But as I said, this could add unnecessary complexity at both server side and
client side code to just safe some bytes in the response 😄 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
