kezhenxu94 commented on code in PR #118:
URL: 
https://github.com/apache/skywalking-showcase/pull/118#discussion_r1148371646


##########
deploy/platform/kubernetes/Makefile.in:
##########
@@ -18,8 +18,8 @@
 
 .EXPORT_ALL_VARIABLES:
 
-NAMESPACE ?= default
+NAMESPACE ?= skywalking-showcase

Review Comment:
   > Does the namespace need to be explicitly specified? This should be the 
default.
   
   @innerpeacez we override the namespace here to `skywalking-showcase`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to