innerpeacez commented on code in PR #125:
URL:
https://github.com/apache/skywalking-showcase/pull/125#discussion_r1174554602
##########
deploy/platform/kubernetes/Makefile:
##########
@@ -136,6 +136,13 @@ feature-kubernetes-monitor:
$(eval HELM_OPTIONS := $(HELM_OPTIONS) --set
kube-state-metrics.enabled=true)
$(eval HELM_OPTIONS := $(HELM_OPTIONS) --set opentelemetry.enabled=true)
+.PHONY: feature-elasticsearch-monitor
+feature-elasticsearch-monitor:
+ $(eval HELM_OPTIONS := $(HELM_OPTIONS) --set
features.elasticsearchMonitor.enabled=true)
+ $(eval HELM_OPTIONS := $(HELM_OPTIONS) --set
prometheus-elasticsearch-exporter.enabled=true)
+ $(eval HELM_OPTIONS := $(HELM_OPTIONS) --set
prometheus-elasticsearch-exporter.es.uri=http://elasticsearch-master:9200)
Review Comment:
I thought about your concerns, and in the end I didn't do it that way.
Instead, I just provided an option, but in this option, only export the ES
metrics used by OAP. If use pgsql as the storage for OAP, the ES will have no
traffic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
