kylixs commented on code in PR #521:
URL: https://github.com/apache/skywalking-java/pull/521#discussion_r1182239454


##########
apm-sniffer/apm-agent/src/main/java/org/apache/skywalking/apm/agent/SkyWalkingAgent.java:
##########
@@ -161,9 +175,10 @@ public DynamicType.Builder<?> transform(final 
DynamicType.Builder<?> builder,
                                                 final JavaModule javaModule,
                                                 final ProtectionDomain 
protectionDomain) {
             LoadedLibraryCollector.registerURLClassLoader(classLoader);
+            DelegateNamingResolver.reset();

Review Comment:
   There seems to be a problem here, I'm not sure if there will be nested 
retransform multiple classes, which usually occurs the first time a class is 
loaded. If so, it would be unreasonable to reset all of them, just reset the 
counter of the class currently being transformed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to